Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skipped data url reported as invalid #5

Closed
chalin opened this issue Dec 19, 2016 · 2 comments
Closed

skipped data url reported as invalid #5

chalin opened this issue Dec 19, 2016 · 2 comments
Assignees

Comments

@chalin
Copy link
Collaborator

chalin commented Dec 19, 2016

When linkcheck is run over https://webdev.dartlang.org/, the following is reported:

http://localhost:4001/angular/api/static-assets/styles.css
- (391:24) url(...) => data:image/svg+xml;utf8,<svg xmlns='http://www.w3.org/2000/svg' width='16' height='16' viewBox='0 0 16 16'><path fill=' (invalid URL)

even if this skip pattern is used:

^data

Note that the skip pattern is being used:

Done checking: http://localhost:4001/angular/api/static-assets/styles.css (HTTP 200) => 3 links
- will not be checking: data:image/svg+xml;utf8,<svg xmlns='http://www.w3.org/2000/svg' width='16' height='16' viewBox='0 0 16 16'><path fill=' - URL 'data:image/svg+xml;utf8,<svg xmlns='http://www.w3.org/2000/svg' width='16' height='16' viewBox='0 0 16 16'><path fill='' skipped because it was matched by the following regular expressions of skip file './scripts/config/linkcheck-skip-list.txt': ^data (line 12)

But the data url is none-the-less being reported as invalid. Here is an actual sample entry:

background-image: url("data:image/svg+xml;utf8,<svg xmlns='http://www.w3.org/2000/svg' width='16' height='16' viewBox='0 0 16 16'><path fill='#DDDDDD' d='M6.7,4L5.7,4.9L8.8,8l-3.1,3.1L6.7,12l4-4L6.7,4z'/></svg>");

Skipped links probably shouldn't have validity checks performed on them. (On the hand, I'd also be curious to know why the data url is being considered invalid.)

@filiph filiph self-assigned this Dec 20, 2016
@filiph
Copy link
Owner

filiph commented Dec 20, 2016

Thanks! Fixed by 39ac0ac.

Also, from now on, unsupported schemes (such as data:) are not reported as warning. So you can remove that line from the skip file.

@filiph filiph closed this as completed Dec 20, 2016
@chalin
Copy link
Collaborator Author

chalin commented Dec 20, 2016

Ok, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants