Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are the HTML-pages cached? #71

Closed
cyfyrifilefe opened this issue Mar 10, 2021 · 3 comments
Closed

Are the HTML-pages cached? #71

cyfyrifilefe opened this issue Mar 10, 2021 · 3 comments

Comments

@cyfyrifilefe
Copy link

Hello, thanks for your work.

I have some questions:

  1. Are HTML-pages cached.
  2. If yes, where?
  3. If not, what code to add and where for caching them?

Cheers,
Lyric ;-)

@filiph
Copy link
Owner

filiph commented Mar 10, 2021

Hi!

The pages are not cached. It would be really hard to figure out when to invalidate the cache. The linkcheck tool kind of assumes now that you're running it locally on your whole site, trying to check all of it. It should be fast enough that we don't need caching.

What's your use case for caching, exactly?

The code for caching would probably live somewhere around https://github.com/filiph/linkcheck/blob/master/lib/src/worker/pool.dart.

@cyfyrifilefe
Copy link
Author

Hi Filiph,

thank you for your response.

I'd like to add some spell-checking on the downloaded HTML pages. Since I don't know Dart. I thought that maybe the pages were cached somewhere.

@filiph
Copy link
Owner

filiph commented Mar 10, 2021

Ah, got it, thanks for the explanation!

I'd like to add some spell-checking on the downloaded HTML pages.

That would be hard to include in linkcheck without making things slower & more complicated. For spell checking, I think wget or curl is probably a better option.

I'm closing this, at least for now.

@filiph filiph closed this as completed Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants