Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github actions: Unable to pass -e #72

Closed
liskin opened this issue Mar 10, 2021 · 3 comments · Fixed by #82
Closed

github actions: Unable to pass -e #72

liskin opened this issue Mar 10, 2021 · 3 comments · Fixed by #82

Comments

@liskin
Copy link

liskin commented Mar 10, 2021

It's not possible to pass both -e and a URI as arguments when using this as a github actions, as

- ${{ inputs.arguments }}
passes it all as a single argument with spaces. Unfortunately https://docs.github.com/en/actions/creating-actions/metadata-syntax-for-github-actions#runsargs looks like this can't be done easily. :-/

I worked it around by forking and adding the flag manually, but that's a terrible hack: liskin@2d34f2f

@filiph
Copy link
Owner

filiph commented Mar 11, 2021

Damn. One of these days I'll take a closer look at GitHub Actions. I'm guessing the best way would be to maintain the list of options in action.yml?

To be clear, I won't have time to actively look into this in the foreseeable future. If there's anyone out there who has the time & motivation to fix it, please send a PR.

@TriplEight
Copy link

Just faced the same thing, can't pass <URL> -e in an action

@StephenFluin
Copy link

It looks like this should have been fixed in #82 342ae58. Is there any reason it wasn't released?

When I try to use 342ae58, with this .yml

jobs:
  check-links:
    name: Regularly check links
    runs-on: ubuntu-latest
    steps:
      - name: Check docs links with linkcheck
        uses: filiph/linkcheck@342ae586489f6bf1113ba2ec793eb806896a3be1
        with:
          arguments: https://example.com/ -e

I get this error:

Download action repository 'filiph/linkcheck@342ae586489f6bf1113ba2ec793eb806896a3be1' (SHA:342ae586489f6bf1113ba2ec793eb806896a3be1)
Error: filiph/linkcheck/342ae586489f6bf1113ba2ec793eb806896a3be1/action.yml (Line: 16, Col: 5): A sequence was not expected
Error: filiph/linkcheck/342ae586489f6bf1113ba2ec793eb806896a3be1/action.yml (Line: 16, Col: 5): A sequence was not expected
Error: System.ArgumentException: Unexpected type 'SequenceToken' encountered while reading 'entrypoint'. The type 'StringToken' was expected.
   at GitHub.DistributedTask.ObjectTemplating.Tokens.TemplateTokenExtensions.AssertString(TemplateToken value, String objectDescription)
   at GitHub.Runner.Worker.ActionManifestManager.ConvertRuns(IExecutionContext executionContext, TemplateContext templateContext, TemplateToken inputsToken, String fileRelativePath, MappingToken outputs)
   at GitHub.Runner.Worker.ActionManifestManager.Load(IExecutionContext executionContext, String manifestFile)
Error: Fail to load filiph/linkcheck/342ae586489f6bf1113ba2ec793eb806896a3be1/action.yml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants