Ungate dataconnect features (#7354)

firebase · Jun 21, 2024 · 9cdbf7e · 9cdbf7e
1 parent 90fdad8
commit 9cdbf7e
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 20 deletions.
diff --git a/src/commands/index.ts b/src/commands/index.ts
@@ -205,17 +205,15 @@ export function load(client: any): any {
   client.setup.emulators.pubsub = loadCommand("setup-emulators-pubsub");
   client.setup.emulators.storage = loadCommand("setup-emulators-storage");
   client.setup.emulators.ui = loadCommand("setup-emulators-ui");
-  if (experiments.isEnabled("dataconnect")) {
-    client.dataconnect = {};
-    client.setup.emulators.dataconnect = loadCommand("setup-emulators-dataconnect");
-    client.dataconnect.services = {};
-    client.dataconnect.services.list = loadCommand("dataconnect-services-list");
-    client.dataconnect.sql = {};
-    client.dataconnect.sql.diff = loadCommand("dataconnect-sql-diff");
-    client.dataconnect.sql.migrate = loadCommand("dataconnect-sql-migrate");
-    client.dataconnect.sdk = {};
-    client.dataconnect.sdk.generate = loadCommand("dataconnect-sdk-generate");
-  }
+  client.dataconnect = {};
+  client.setup.emulators.dataconnect = loadCommand("setup-emulators-dataconnect");
+  client.dataconnect.services = {};
+  client.dataconnect.services.list = loadCommand("dataconnect-services-list");
+  client.dataconnect.sql = {};
+  client.dataconnect.sql.diff = loadCommand("dataconnect-sql-diff");
+  client.dataconnect.sql.migrate = loadCommand("dataconnect-sql-migrate");
+  client.dataconnect.sdk = {};
+  client.dataconnect.sdk.generate = loadCommand("dataconnect-sdk-generate");
   client.target = loadCommand("target");
   client.target.apply = loadCommand("target-apply");
   client.target.clear = loadCommand("target-clear");

diff --git a/src/commands/init.ts b/src/commands/init.ts
@@ -81,13 +81,11 @@ if (isEnabled("genkit")) {
   });
 }
 
-if (isEnabled("dataconnect")) {
-  choices.push({
-    value: "dataconnect",
-    name: "Data Connect: Set up a Firebase Data Connect service.",
-    checked: false,
-  });
-}
+choices.push({
+  value: "dataconnect",
+  name: "Data Connect: Set up a Firebase Data Connect service.",
+  checked: false,
+});
 
 const featureNames = choices.map((choice) => choice.value);
 

diff --git a/src/experiments.ts b/src/experiments.ts
@@ -121,9 +121,10 @@ export const ALL_EXPERIMENTS = experiments({
     public: false,
   },
 
+  // TODO(joehanley): Delete this once weve scrubbed all references to experiment from docs.
   dataconnect: {
-    shortDescription: "Enable Data Connect related features.",
-    fullDescription: "Enable Data Connect related features.",
+    shortDescription: "Deprecated. Previosuly, enabled Data Connect related features.",
+    fullDescription: "Deprecated. Previously, enabled Data Connect related features.",
     public: false,
   },