Fix res.body.connectors is not iterable error on deploy --only dataco…

…nnect (#7353)
firebase · Jun 21, 2024 · e1a81f8 · e1a81f8
1 parent 0975e74
commit e1a81f8
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -0,0 +1 @@
+- Fixes issue where `deploy --only dataconnect` would error out with `cannot read property undefined`.
diff --git a/src/dataconnect/client.ts b/src/dataconnect/client.ts
@@ -154,15 +154,15 @@ export async function listConnectors(serviceName: string) {
   const connectors: types.Connector[] = [];
   const getNextPage = async (pageToken = "") => {
     const res = await dataconnectClient().get<{
-      connectors: types.Connector[];
-      nextPageToken: string;
+      connectors?: types.Connector[];
+      nextPageToken?: string;
     }>(`${serviceName}/connectors`, {
       queryParams: {
         pageSize: PAGE_SIZE_MAX,
         pageToken,
       },
     });
-    connectors.push(...res.body.connectors);
+    connectors.push(...(res.body.connectors || []));
     if (res.body.nextPageToken) {
       await getNextPage(res.body.nextPageToken);
     }
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		- Fixes issue where `deploy --only dataconnect` would error out with `cannot read property undefined`.