Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exception in API when calling chart #7992

Closed
4 tasks done
victorbalssa opened this issue Sep 23, 2023 · 3 comments
Closed
4 tasks done

Exception in API when calling chart #7992

victorbalssa opened this issue Sep 23, 2023 · 3 comments
Labels
fixed Bugs that are fixed (in a coming release).

Comments

@victorbalssa
Copy link

Support guidelines

I've found a bug and checked that ...

Description

when accessing https://api-docs.firefly-iii.org/?urls.primaryName=2.0.8%20(v2)#/charts/getBalanceChart

it uses the BalanceChartRequest->getAccountList() which throw (L.175):

  • FireflyException('uses old administration ID check, needs to be updated.G')

public function getAccountList(): Collection
{
// fixed
/** @var AccountRepositoryInterface $repository */
$repository = app(AccountRepositoryInterface::class);
// set administration ID
// group ID
$administrationId = auth()->user()->getAdministrationId();
throw new FireflyException('uses old administration ID check, needs to be updated.G');
$repository->setAdministrationId($administrationId);

I was wondering if we could update this endpoint to remove the error thrown?

Debug information

x

Expected behaviour

No response

Steps to reproduce

No response

Additional info

No response

@JC5 JC5 changed the title uses old administration ID check, needs to be updated.G Exception in API when calling chart Sep 24, 2023
@JC5
Copy link
Member

JC5 commented Sep 24, 2023

Yes, perhaps we could 🤔

@JC5 JC5 added bug fixed Bugs that are fixed (in a coming release). labels Sep 24, 2023
@JC5 JC5 added this to Firefly III Sep 24, 2023
@JC5 JC5 moved this to To do in Firefly III Sep 24, 2023
@JC5 JC5 added this to the firefly-iii-v6.0.25 milestone Sep 24, 2023
@JC5
Copy link
Member

JC5 commented Sep 24, 2023

Fixed! 👍

@JC5 JC5 closed this as completed in 94c1906 Sep 24, 2023
@github-actions
Copy link
Contributor

Hi there! This is an automatic reply. Share and enjoy

This issue is now 🔒 closed. Please be aware that closed issues are not monitored by the developer of Firefly III.

  • If the original bug is not actually fixed, please open a new issue. Refer to this issue for clarity.
  • Follow-up questions must be posted in a new discussion
  • Further replies to this issue may get no response.

If there is more to discuss, please open a new issue or discussion.

Thank you for your contributions.

@JC5 JC5 removed this from Firefly III Oct 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
fixed Bugs that are fixed (in a coming release).
Projects
None yet
Development

No branches or pull requests

2 participants