Upgrade Docker container to 4.6.5 #856
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey man, thanks for the commit! I knew I forgot something. Unfortunately, I can't update the master branch. Could you edit your commit so it goes to the develop branch? |
|
Now it has conflicts as the docker container in develop is built with COPY from the repo. Besides, when the next version is released, this will have to be updated again. What do we do about it? Or it might be because I branched this out of master, with intention to merge into master |
|
Yeah, merging this to develop does not make sense |
|
Mmm that's true. I'll have to close this and add it to my todo list for the next release. Is that ok? |
|
sure. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like this has been missed