Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some minor color issues #8613

Closed
4 tasks done
rumpff opened this issue Mar 3, 2024 · 3 comments
Closed
4 tasks done

Some minor color issues #8613

rumpff opened this issue Mar 3, 2024 · 3 comments
Labels
fixed Bugs that are fixed (in a coming release).

Comments

@rumpff
Copy link

rumpff commented Mar 3, 2024

Support guidelines

I've found a bug and checked that ...

Description

I have found a few theme specific color issues, for each of them the system theme was set to dark

Debug information

Debug information generated at 2024-03-03 05:57:41 for Firefly III version v6.1.9.

System information
ItemValue
Firefly III6.1.9 / v2.0.12 / 22 (exp. 22)
PHP version8.3.2 / apache2handler / Linux
BCscale12
Error reportingDisplay: Off, reporting: ALL errors
Max upload67108864 (64 MB)
Database drivers*mysql*, pgsql, sqlite,
Docker build#957, base #79
Firefly III information
ItemValue
TimezoneEurope/Amsterdam + Europe/Amsterdam
App environmentlocal, debug: false
Layoutv1
Loggingnotice, stack / (empty)
Cache driverfile
Default language and localeen_US + equal
Trusted proxies**
Login provider & user guardeloquent / web
Login headersN/A + N/A
Stateful domains
Last cron jobnever (never)
Mailerlog
User-specific information
ItemValue
User#1 of 1
User flags🔧 📑 📧
Session start2024-03-01 00:00:00
Session end2024-03-31 23:59:59
View range1M
User languageen_US
User localeen_US
Locale(s) supporteden_US.utf8: ✅
en_US.UTF-8: ✅
User agentMozilla/5.0 (Windows NT 10.0; Win64; x64; rv:123.0) Gecko/20100101 Firefox/123.0

Expected behaviour

1: (Dark mode) In options \ preferences the fiscal year calendar icon has a white border, while the date picker (and every other button) does not
image

potiential fix: use same color as the date selection #272c30

image

2: (Dark mode) In options \ administration the Clear cache button text has very bad contrast with the yellow button
image

potiential fix: use pure white for the text
image

3: (Dark mode) In options \ preferences if you hover over the selected tab title it dims down instead of every tab instead of the selected tab like in light mode, also the color makes it difficult to read due to the contrast
image

potiential fix: Use same hover behaviour like in light mode, and change the color to a brighter color. for example #717478 (this is the old unhovered color with the same brightness difference (33%) as used in the light mode)
image

4: (Dark mode) Larger dividers, like the ones in bills, classification \ groups, options \ currencies, options \ profile \ oauth, are bright white
image

potiential fix: Use the same color as the other thinner borders #353c42
image

5: (Dark mode) The color of trash buttons icon clashes with the red button
image

potiential fix: Change icon color to pure white
image

6: (Dark mode) The borders in options \ preferences are bright white
image

potiential fix: Change color to universal border color #353c42
image

7: (Light mode) When the system theme is in dark mode, but firefly is set to light mode checkboxes and tickboxes still have a dark background
image

potiential fix: Use light background
image

Steps to reproduce

No response

Additional info

No response

@JC5
Copy link
Member

JC5 commented Mar 3, 2024

Nice, thanks. Any CSS tips for the check boxes are welcome, I have not yet been able to make them consistently light.

@rumpff
Copy link
Author

rumpff commented Mar 3, 2024

it might be easier to make a custom checkbox instead of relying on the broswer's native checkbox/tickbox

@JC5
Copy link
Member

JC5 commented Mar 3, 2024

Maybe in the new layout then 😀

@JC5 JC5 added the bug label Mar 3, 2024
@JC5 JC5 added this to Firefly III Mar 3, 2024
@JC5 JC5 moved this to To do in Firefly III Mar 3, 2024
@JC5 JC5 added the fixed Bugs that are fixed (in a coming release). label Apr 19, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 15, 2024
@JC5 JC5 removed this from Firefly III Aug 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
fixed Bugs that are fixed (in a coming release).
Projects
None yet
Development

No branches or pull requests

2 participants