Introduce batch fk capabilities for floating and planar joints #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le batched inputs.
… the DOF of planar and floating joints
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, it seemed like urchin's batched forwards kinematics functions didn't have support for planar and floating joints. I went through updated the relevant functions to add that support. To also simplify the forwards kinematics for those two joint types, I added functionality that would unpack a flat list or numpy array to the corresponding 2dof or 6dof inputs for those joints.
So, if you have a planar joint followed by a revolute joint, you can now do [x_val, y_val, rot_val] as your list input instead of [[x_val, y_val], rot_val], which helps with the numpy batching form for forward kinematics.
I also noticed that there were extra None type checks in
get_child_poseandget_child_poses, so I also went ahead and removed those in one of those commits, but if that's a no-go, I can remove that commit.