From ec9417b5d48a2885cdff79d1d0baad07925e61ba Mon Sep 17 00:00:00 2001 From: Axel Viala Date: Tue, 11 Oct 2022 13:42:24 +0200 Subject: [PATCH] [clippy] use into_values in mod.rs. rationale: ``` warning: iterating on a map's values --> src/json/map/mod.rs:94:24 | 94 | let tilesets = other | ________________________^ 95 | | .tilesets 96 | | .into_iter() 97 | | .map(|(_, tileset)| tileset) | |________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_kv_map = note: `#[warn(clippy::iter_kv_map)]` on by default help: try | 94 ~ let tilesets = other 95 + .tilesets.into_values() | ``` --- src/json/map/mod.rs | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/json/map/mod.rs b/src/json/map/mod.rs index c13586ec4e..1c4452e51a 100644 --- a/src/json/map/mod.rs +++ b/src/json/map/mod.rs @@ -91,11 +91,7 @@ impl From for MapDef { }) .collect(); - let tilesets = other - .tilesets - .into_iter() - .map(|(_, tileset)| tileset) - .collect(); + let tilesets = other.tilesets.into_values().collect(); MapDef { background_color: other.background_color,