Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up docs and installation guide #165

Merged
merged 2 commits into from
Jan 4, 2021
Merged

Clean up docs and installation guide #165

merged 2 commits into from
Jan 4, 2021

Conversation

kwigley
Copy link
Contributor

@kwigley kwigley commented Jan 4, 2021 •
edited
Loading

resolves #164

Description

  • rm yarn (use npm)
  • update development docs
  • rm unnecessary package (uglifyjs-webpack-plugin)
  • upgrade dependencies
  • confirmed the README dev instructions work for a fresh installation

Checklist

  • I have signed the CLA
  • I have generated docs locally, and this change appears to resolve the stated issue
  • I have updated the CHANGELOG.md and added information about my change to the "dbt next" section.

@cla-bot cla-bot bot added the cla:yes label Jan 4, 2021
@kwigley kwigley requested review from drewbanin and jtcohen6 January 4, 2021 19:26
drewbanin
drewbanin approved these changes Jan 4, 2021
View reviewed changes
Copy link
Contributor

@drewbanin drewbanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! This LGTM

jtcohen6
jtcohen6 approved these changes Jan 4, 2021
View reviewed changes
Copy link
Contributor

@jtcohen6 jtcohen6 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! Love it

@kwigley kwigley merged commit 97570c5 into master Jan 4, 2021
@kwigley kwigley deleted the fix/installation-docs branch January 4, 2021 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtcohen6 jtcohen6 jtcohen6 approved these changes

@drewbanin drewbanin drewbanin approved these changes

Assignees
No one assigned
Labels
cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

yarn install fails
3 participants
@kwigley @drewbanin @jtcohen6