-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add options clause to create table macro #171
Add options clause to create table macro #171
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm all about it! Thanks @JCZuurmond, this looks great.
My only ask: Could you add options
to the SparkConfig
class here? That's where we track adapter-specific configs that can be set in dbt_project.yml
, be recorded in manifest.json
, and may or may not want custom validation.
Done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @JCZuurmond!
resolves #147
Description
Adds an option clause macro which allows for adding options to a table via the config:
Heavily inspired on #148. @friendofasquid : I went ahead, implemented a solution based on the examples you created, here to contribute back.
Checklist
CHANGELOG.md
and added information about my change to the "dbt next" section.