Initial Review and Publishing Process

[ppaulweber]

In order to have this data source plugin published in the Grafana plugin catalog we have received the following change requests:

• provide missing hide functionality (either frontend or backend side) of a given data source
• rework the metric query mode user experience
• handle query state changes correctly in the frontend to only send necessary JSON data along with the query request
• provide clear separation of plugin.Datasource configuration and JSON data model and JSON secrets, see:

  grafana.surrealdb/pkg/plugin/datasource.go

  Line 43 in fcd65cf

  Password string `json:"password"` // secrets

• remove necessary getResource frontend calls and still not used backend logic, see: https://github.com/fiskaly/grafana.surrealdb/blob/v0.1.0/src/datasource.ts#L26 and

  grafana.surrealdb/pkg/plugin/datasource.go

  Lines 636 to 655 in fcd65cf

  	func (r *Datasource) CallResource(ctx context.Context, request *backend.CallResourceRequest, response backend.CallResourceResponseSender) error {
  	// log.DefaultLogger.Info(fmt.Sprintf("CallResource: %s", request.Path))
  	switch request.Path {
  	// case "TODO":
  	// return response.Send(
  	// &backend.CallResourceResponse{
  	// Status: http.StatusOK,
  	// Body: []byte(`{}`),
  	// },
  	// )
  	default:
  	return response.Send(
  	&backend.CallResourceResponse{
  	Status: http.StatusNotFound,
  	Body: []byte(`{}`),
  	},
  	)
  	}
  	}

• replace the panic() with an empty string, see:

  grafana.surrealdb/pkg/plugin/datasource.go

  Line 221 in fcd65cf

  panic(fmt.Sprintf("invalid QueryMode state '%d'", r))

• remove query syntax checks and use directly the checks by the underlying data source, see:

  grafana.surrealdb/pkg/plugin/datasource.go

  Lines 279 to 284 in fcd65cf

  	if strings.HasPrefix(surql, "select") == false &&
  	strings.HasPrefix(surql, "SELECT") == false &&
  	strings.HasPrefix(surql, "info") == false &&
  	strings.HasPrefix(surql, "INFO") == false &&
  	strings.HasPrefix(surql, "return") == false &&
  	strings.HasPrefix(surql, "RETURN") == false {