Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] The description for field source_type is too long #18

Closed
3 of 4 tasks
calkan-cue opened this issue Jul 10, 2023 · 5 comments
Closed
3 of 4 tasks

[Bug] The description for field source_type is too long #18

calkan-cue opened this issue Jul 10, 2023 · 5 comments
Assignees
Labels
error:forced priority:p4 Affects few users; pick up when available status:in_review Currently in review type:bug Something is broken or incorrect update_type:documentation Primary focus requires documentation updates

Comments

@calkan-cue
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Describe the issue

The docs part of the source_type columns is too long in bigquery

Relevant error log or model output

12:18:50  38 of 133 START sql table model dbt_t_app_store.stg_apple_store__crashes_platform_version  [RUN]
12:18:51  Unhandled error while executing target/run/apple_store_source/models/stg_apple_store__app_store_territory.sql
400 PATCH https://bigquery.googleapis.com/bigquery/v2/projects/dlake/datasets/dbt_t_app_store/tables/stg_apple_store__app_store_territory?prettyPrint=false: The description for field source_type is too long. The maximum length is 1024 characters.

Expected behavior

running without issue or shorter description for that field

dbt Project configurations

app_reporting:
+schema: app_reporting
apple_store:
+schema: apple_store
apple_store_source:
+schema: app_store

google_play:
+schema: google_play
google_play_source:
+schema: google_play

Package versions

  • package: fivetran/app_reporting
    version: [">=0.3.0", "<0.4.0"]

What database are you using dbt with?

bigquery

dbt Version

Core:

  • installed: 1.4.5
    Plugins:
  • bigquery: 1.4.1

Additional Context

No response

Are you willing to open a PR to help address this issue?

  • Yes.
  • Yes, but I will need assistance and will schedule time during our office hours for guidance
  • No.
@fivetran-joemarkiewicz
Copy link
Collaborator

Hi @calkan-cue thanks for opening this issue. I have actually never seen an issue like this occur and do not see it when I run the package locally on our BigQuery instance. Do you by chance have any other configs in your dbt project that could be attributing to the runtime error (as I don't imagine the docs should have an impact at runtime).

I do see you have prettyPrint=false in the run log. Are you persisting these docs to the warehouse by chance? I wonder if that is the contributing factor as to why I am unable to see this error locally on my end.

@calkan-cue
Copy link
Author

Yes we are persisting these docs to the warehouse. Maybe you can see the same if you try as I do.

@calkan-cue
Copy link
Author

Will there be any action for the ones those persisting the docs in the warehouse or should I just go with override of the documents ? @fivetran-joemarkiewicz

@fivetran-joemarkiewicz
Copy link
Collaborator

Hi @calkan-cue apologies for the delay, we are bringing this issue into our current sprint and will share more as we investigate and work towards a fix.

@fivetran-reneeli fivetran-reneeli self-assigned this Jul 18, 2023
@fivetran-reneeli fivetran-reneeli added priority:p4 Affects few users; pick up when available type:bug Something is broken or incorrect status:in_review Currently in review update_type:documentation Primary focus requires documentation updates labels Jul 26, 2023
@fivetran-reneeli
Copy link
Contributor

Hey @calkan-cue! Thanks for opening this up. Our latest release of this package (v0.3.2) addresses this. As such we'll be closing this issue, but let us know if there's anything else!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
error:forced priority:p4 Affects few users; pick up when available status:in_review Currently in review type:bug Something is broken or incorrect update_type:documentation Primary focus requires documentation updates
Projects
None yet
Development

No branches or pull requests

3 participants