Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kittyMod can be updated #17

Open
page-down opened this issue Jan 18, 2022 · 2 comments
Open

kittyMod can be updated #17

page-down opened this issue Jan 18, 2022 · 2 comments
Assignees
@fladson
Labels
good first issue Good for newcomers hacktoberfest

Comments

@page-down
Copy link

page-down commented Jan 18, 2022 •
edited
Loading

The recently released kitty version actually includes some of my modifier key name updates.

I'm just letting you know that maybe you'd like to update kittyMod, thanks. :)

https://github.com/kovidgoyal/kitty/blob/v0.24.0/kitty/options/utils.py#L39-L40

It is worth noting that for ctrl, ⌃ is a Unicode character.
@fladson fladson self-assigned this Jan 20, 2022
@fladson
Copy link
Owner

fladson commented Jan 20, 2022

Thanks for the heads up, I will take care of that.

@fladson fladson added the good first issue Good for newcomers label Jan 20, 2022
@fladson
Copy link
Owner

fladson commented Jan 20, 2022

I realized we don't have a match for invalid mods, so anything you put after map will be highlighted.
I will try to refactor the regexes to cover that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fladson fladson

Labels
good first issue Good for newcomers hacktoberfest
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fladson @page-down