Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make upstream systemd-sysext reload the units by default #984

Closed
pothos opened this issue Mar 24, 2023 · 4 comments
Closed

Make upstream systemd-sysext reload the units by default #984

pothos opened this issue Mar 24, 2023 · 4 comments
Assignees
Labels
area/sysext sysext roadmap

Comments

@pothos
Copy link
Member

pothos commented Mar 24, 2023

Make upstream systemd-sysext reload the units by default: systemd-sysext refresh should also issue a daemon-reload as done by systemctl enable X, this allows us to drop this line https://github.com/flatcar/init/blob/fbb1ec8e9d95598d65e4eac408dbc5f75b9b6138/systemd/system/ensure-sysext.service#L14

Since this will start units through Upholds= as upstream-supported way, document that mechanism in the systemd-sysext manpage.
@tormath1 mentioned that we should also look for any downsides compared to Wants=.
Edit: Filed systemd/systemd#26896 for that.

@tormath1
Copy link
Contributor

Upstream PR is merged.

@tormath1
Copy link
Contributor

As the issue concern the upstream feature, I guess we can close this one?

@pothos
Copy link
Member Author

pothos commented Aug 22, 2023

Yes, thanks a lot!
Do we want to backport this when we update to 254?

@tormath1
Copy link
Contributor

@pothos patch can be applied correctly against v254-stable - there is a trivial conflict on the test/test-functions but it can be cleanly solved by backporting this commit too: systemd/systemd@b856f1d.
So yes, we can backport this during the update to 254 (and merge this: flatcar/init#96)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/sysext sysext roadmap
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants