Drop unused packages #2607
Merged
Drop unused packages #2607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI passed. |
|
Build action triggered: https://github.com/flatcar/scripts/actions/runs/12948305869 |
chewi
reviewed
Jan 24, 2025
We had those packages in portage-stable, but nothing pulled them in. These packages add groups that exist in group file in baselayout, which we would want to get rid of eventually.
It used to be pulled in by net-misc/iputils, but now this happens only for 9999 version of the package, which we don't use.
I think I pulled the package from Gentoo in order to update some protobuf package, which needed abseil. But it fizzled out once I realized that update_engine needs to be updated first to the new version of protobuf library.
Mentions of virtual/rust in some scripts were replaced with dev-lang/rust-bin. These were usually about skipping the update/build of the package, and these already contained dev-lang/rust, so added the -bin variant for completeness.
krnowak
force-pushed
the
krnowak/package-cleanups
branch
from
67e000e to
64f1595
Compare
chewi
approved these changes
Jan 24, 2025
There was a problem hiding this comment.
I was a little surprised to see udisks being dropped, but it does appear to be more of a desktop thing. It is used by fwupd though, which got me wondering whether we should include that for bare metal users. Probably not something you should run in a container.
|
Eh, scratch that, it's written in Python. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI: http://jenkins.infra.kinvolk.io:8080/job/container/job/sdk/1920/cldsv/
This is mostly about dropping unused packages and cleaning up related entries in profiles.
I also added two group packages to the production images - they should have been there, but probably something stopped pulling them at some point, so I'm bringing them back. I hope to use them to eventually get rid of the passwd and group files from baselayout.
/bootand/usrsize, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.