Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flatpak version of Pulsar does not follow system theme properly #3

Closed
ghost opened this issue Mar 11, 2023 · 5 comments
Closed

Flatpak version of Pulsar does not follow system theme properly #3

ghost opened this issue Mar 11, 2023 · 5 comments

Comments

@ghost
Copy link

ghost commented Mar 11, 2023

This is what the flatpak version looks like: (The menubar is white even though dark theme is used for both the desktop and for Pulsar)
pulsar-flatpak

This is how I expect it to look, and how it does look if I install pulsar as RPM:
flatpak-rpm

System: Fedora 37 KDE spin, Wayland

@cat-master21
Copy link
Collaborator

This is an issue with Pulsar, pulsar-edit/pulsar#422. Though as for the menubar not syncing with the system theme is an issue with the flatpak version.

@ghost
Copy link
Author

ghost commented Jun 6, 2023

I'm not sure what changed but the menubar now correctly follows the system theme.

@cat-master21
Copy link
Collaborator

Thanks for the feedback @aylamz I will close this issue then.

@ghost
Copy link
Author

ghost commented Jun 13, 2023

Update: I re-installed Fedora and this issue has appeared again for some reason. Pulsar is not the only Flatpak that does not follow system theme properly though so maybe this is a Fedora or KDE issue. I'll open an issue on KDE bugtracker to see what they think.

Edit: https://bugs.kde.org/show_bug.cgi?id=470972

@confused-Techie
Copy link
Contributor

I do want to chime in real quick to say I have an open PR within Pulsar to address part of this issue. This PR specifically aims to change the Pulsar window theme along with the theme used within Pulsar it does nothing to address the theme matching the system theme.

If the folks here would like to test this behavior and see how it works within the flakpak version I'd be glad to hear if it improves the situation.

Elsewhere within Pulsar we are seeing mixed success with this PR. It seems the Window Theme of the Pulsar application doesn't change as we would expect within some platforms due to issues with our current Electron version. But this PR does show promise to change the Menu Bar theme properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants