-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add libmpv #284
Comments
That's not an argument. |
It has tons of deps and without auto-updating it's rather unmaintainable as shared-module |
It is quite complex and regularly updating, which makes it both a good and bad idea. I try to keep the Celluloid one updated and it looks like none of the others are up to date. So sharing that work would be nice. |
for Celluloid bot do updates for shared-modules it won't. Also bumping shared-modules in app repo is rare thing. |
If the lack of auto updating dependecies is not possible for shared modules, then how about having a regular flatpak package that is auto updated and then synced here?
There are 8 other apps with up to date mpv haruna |
That is a big problem then.
I'm not sure about your wording but there aren't "flatpak packages" really. |
If someone would like to take over my auto updater work for shared-modules, that would solve the out-of-date problem here, thus only leaving the main point, "mpv is complex". |
No, that would solve only half of the out-of-date problem. The second part is that f-e-d-c doesn't update submodules so everyone would need to bump it manually. |
It might be possible to get the bot to check for a submodule named |
Not yet - monorepo contains dozens of modules while app may use 1-2 of them. Bumping submodule for each commit would results with useless updates for maintainers and useless updates for end users. Making bot aware of subpaths is complicated as noted in the linked thread. |
While extra work I don't think its that crazy. In the manifest a module is either a string or an object. For strings they map to paths. With some effort you can see if those paths changed. |
It takes a while to build and there are ~20 apps using it https://github.com/search?q=org%3Aflathub%20libmpv&type=code
The text was updated successfully, but these errors were encountered: