Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] FadeRAWA allows invisible widgets to receive gesture events #1589

Closed
ddshd opened this issue Jul 16, 2023 · 3 comments · Fixed by #1591
Closed

[BUG] FadeRAWA allows invisible widgets to receive gesture events #1589

ddshd opened this issue Jul 16, 2023 · 3 comments · Fixed by #1591
Labels
bug This issue reports broken functionality or another error P: 1 (important)

Comments

@ddshd
Copy link

ddshd commented Jul 16, 2023

What is the bug?

On iOS (only tested on iOS) - Using the following code the "OpenStreetMap contributors" text is still tappable even through it does not show up on the screen. If a user is to tab in the general location of where the text would be the link opens

How can we reproduce it?

Using the following on a FlutterMap

                nonRotatedChildren: [
                  RichAttributionWidget(
                    attributions: [
                      TextSourceAttribution(
                        'OpenStreetMap contributors',
                        onTap: () => launchUrl(
                          Uri.parse('https://openstreetmap.org/copyright'),
                        ),
                      ),
                    ],
                  ),
                ],

Tap the "info" button to see where the text would be, close the widget, and tab in the region where the text would be if the widget was open.. This will cause the link to be launched

Do you have a potential solution?

Haven't looked deep into how the widget is shown/hidden but maybe it's done through opacity then the items would still interactive even though they are not seen

Platforms

iOS 16

Severity

Minimum: Allows normal functioning

@ddshd ddshd added bug This issue reports broken functionality or another error needs triage This new bug report needs reproducing and prioritizing labels Jul 16, 2023
@JaffaKetchup
Copy link
Member

Hi @ddshd,

I can't reproduce this on Android, and I'm not sure why there would be platform specific behaviour here.

Screenrecorder-2023-07-17-06-58-45-792.1.mp4

Can you reproduce on iOS with the example app?

@ddshd
Copy link
Author

ddshd commented Jul 17, 2023

Screen.Recording.2023-07-17.at.1.26.17.AM.mov

I should also note that we do not have the following set, we are just using the default value.. I commented the line out to reproduce it. Apologies.

animationConfig: const ScaleRAWA(),

Edit: Updated video so that you can see the taps

@JaffaKetchup JaffaKetchup added P: 1 (important) and removed needs triage This new bug report needs reproducing and prioritizing labels Jul 17, 2023
@JaffaKetchup
Copy link
Member

Ok, thanks for that extra information. I can now reproduce it.
The fade animation uses AnimatedOpacity, which I should've realised won't stop gesture events at 0%. The scale animation is not a problem because the container becomes 0x0px.

@JaffaKetchup JaffaKetchup changed the title [BUG] Links inside RichAttributionWidget are tappable even if the widget is closed [BUG] FadeRAWA allows invisible widgets to receive gesture events Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue reports broken functionality or another error P: 1 (important)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants