-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Video.configuration
property, instance of VideoConfiguration
class
#3074
Conversation
Thanks! I guess we have to merge this before you can try it, right? |
I meant @bl1nch, not me. 😉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's merge and see if it works...
@ndonkoHenri sorry I'm new in this project, how I can build apk with these changes to test it? Tried to install cloned flet with poetry but when I build apk with flet_video I get:
|
Will let you know when you can test it. |
Maybe we should implement |
Nice idea! |
Sorry, have you already started implementing this? I haven't written in flutter or dart before, I'm afraid I won't be able to implement it in the near future. |
No worries, thanks for your contribution! Will wrap this up :) |
Created |
Video.configuration
property, instance of VideoConfiguration
class
…class (flet-dev#3074) * Make VideoController using 'gpu' vo * create parseControllerConfiguration util * Video: configuration property, instance of VideoConfiguration * Use `self.__configuration` instead of `self.configuration` * Video.before_update: replace self.configuration by self.__configuration --------- Co-authored-by: ndonkoHenri <[email protected]> Co-authored-by: TheEthicalBoy <[email protected]>
media-kit/media-kit#614
#3072