Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possibility to use Page.show_...() methods without argument #3173

Closed
Tracked by #3172
bleudev opened this issue May 2, 2024 · 4 comments · Fixed by #3172
Closed
Tracked by #3172

Add possibility to use Page.show_...() methods without argument #3173

bleudev opened this issue May 2, 2024 · 4 comments · Fixed by #3172

Comments

@bleudev
Copy link
Contributor

bleudev commented May 2, 2024

Please Describe The Problem To Be Solved

f. e. i want to show drawer, but i don't want to define argument in Page.show_drawer() method. Then i must use this code:

page.drawer = ...
page.show_drawer(page.drawer)

I want to use this code:

page.drawer = ...
page.show_drawer()

(Optional): Suggest A Solution

    @overload
    def show_drawer(self) -> None: ...
    @overload
    def show_drawer(self, drawer: NavigationDrawer) -> None: ...
    def show_drawer(self, drawer = None) -> None:
        if drawer:
            self.drawer = drawer
        self.drawer.open = True
        self.update()
@FeodorFitsner
Copy link
Contributor

Would you care for PR? ;)

@bleudev
Copy link
Contributor Author

bleudev commented May 6, 2024

Would you care for PR? ;)

Already. I have opened this issue for it

@FeodorFitsner
Copy link
Contributor

What PR is that?

@bleudev
Copy link
Contributor Author

bleudev commented May 8, 2024

What PR is that?

#3172

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants