Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor numbers.dart utils #3263

Merged
merged 10 commits into from
May 26, 2024
Merged

Refactor numbers.dart utils #3263

merged 10 commits into from
May 26, 2024

Conversation

ndonkoHenri
Copy link
Contributor

@ndonkoHenri ndonkoHenri commented May 10, 2024

Part of #3186

Tasks

The below utility methods are refactored to return null as default value.

  • parseInt
  • parseDouble
  • parseBool

See utils/themes.dart for the main motivation behind this refactoring.

@ndonkoHenri ndonkoHenri marked this pull request as ready for review May 10, 2024 23:02
@ndonkoHenri ndonkoHenri requested a review from FeodorFitsner May 10, 2024 23:02
@FeodorFitsner
Copy link
Contributor

Could you check/resolve a conflict here please?

# Conflicts:
#	packages/flet/lib/src/utils/text.dart
# Conflicts:
#	packages/flet/lib/src/controls/scrollable_control.dart
#	packages/flet/lib/src/utils/alignment.dart
#	packages/flet/lib/src/utils/borders.dart
#	packages/flet/lib/src/utils/colors.dart
#	packages/flet/lib/src/utils/drawing.dart
#	packages/flet/lib/src/utils/edge_insets.dart
#	packages/flet/lib/src/utils/gradient.dart
#	packages/flet/lib/src/utils/images.dart
#	packages/flet/lib/src/utils/text.dart
#	packages/flet/lib/src/utils/theme.dart
#	packages/flet/lib/src/utils/transforms.dart
#	packages/flet_video/lib/src/utils/video.dart
@FeodorFitsner FeodorFitsner merged commit fffb267 into main May 26, 2024
2 checks passed
@ndonkoHenri ndonkoHenri deleted the refactor-numbers-utils branch May 26, 2024 01:31
zrr1999 pushed a commit to zrr1999/flet that referenced this pull request Jul 17, 2024
* refactor parseInt

* refactor parseDouble

* refactor parseBool

* Fix errors

* Fix error in transforms.dart
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants