-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor numbers.dart
utils
#3263
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Could you check/resolve a conflict here please? |
# Conflicts: # packages/flet/lib/src/utils/text.dart
# Conflicts: # packages/flet/lib/src/controls/scrollable_control.dart # packages/flet/lib/src/utils/alignment.dart # packages/flet/lib/src/utils/borders.dart # packages/flet/lib/src/utils/colors.dart # packages/flet/lib/src/utils/drawing.dart # packages/flet/lib/src/utils/edge_insets.dart # packages/flet/lib/src/utils/gradient.dart # packages/flet/lib/src/utils/images.dart # packages/flet/lib/src/utils/text.dart # packages/flet/lib/src/utils/theme.dart # packages/flet/lib/src/utils/transforms.dart # packages/flet_video/lib/src/utils/video.dart
FeodorFitsner
approved these changes
May 25, 2024
zrr1999
pushed a commit
to zrr1999/flet
that referenced
this pull request
Jul 17, 2024
* refactor parseInt * refactor parseDouble * refactor parseBool * Fix errors * Fix error in transforms.dart
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #3186
Tasks
The below utility methods are refactored to return
null
as default value.parseInt
parseDouble
parseBool
See
utils/themes.dart
for the main motivation behind this refactoring.