Cleanup #3406
Merged
Cleanup #3406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @ndonkoHenri - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 5 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟡 Complexity: 1 issue found
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
This was referenced Jun 1, 2024
Merged
| control.open = False | ||
| base.update() | ||
| control.update() |
There was a problem hiding this comment.
Shall we remove control from self.__offstage.controls?
There was a problem hiding this comment.
We could eventually...
Any reason for that?
| @@ -2210,6 +2181,8 @@ def banner(self) -> Optional[Banner]: | |||
| @banner.setter | |||
| def banner(self, value: Optional[Banner]): | |||
| self.__banner = value | |||
| if value is not None: | |||
| self.__controls.append(value) | |||
There was a problem hiding this comment.
Shall we check that value is already in self.__controls?
...and I think deprecation notice should say "use page.open(banner) instead of adding to overlay?
The same applies to other popups.
Co-authored-by: Feodor Fitsner <[email protected]>
FeodorFitsner
approved these changes
Jun 10, 2024
zrr1999
pushed a commit
to zrr1999/flet
that referenced
this pull request
Jul 17, 2024
* cleanup * TimePicker/DatePicker: deprecate pick_time * FlashLight: await coroutines * Usercontrol: deprecation well done * fix bugs * Cleanup * reformat * Page: type hint for *controls __update * Page: added open/close + deprecated open_* and close_* functions * update handler's typing * pass flutter 3.22.1 CI build * update deprecation delete_version * Review commit: replace overlay by __offstage.controls Co-authored-by: Feodor Fitsner <[email protected]> --------- Co-authored-by: Feodor Fitsner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.