Prettify "build" command cli output #3407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @ndonkoHenri - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 3 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
| @@ -843,7 +857,7 @@ def run(self, args, cwd, capture_output=True): | |||
| windll.kernel32.SetConsoleOutputCP(65001) | |||
|
|
|||
| if self.verbose > 0: | |||
| print(f"\nRun subprocess: {args}") | |||
| console.print(f"\nRun subprocess: {args}") | |||
There was a problem hiding this comment.
suggestion: Subprocess output should be logged
Consider logging the subprocess output instead of printing it to the console. This will help in debugging and keeping a record of the operations performed.
Suggested change
| console.print(f"\nRun subprocess: {args}") | |
| import logging | |
| logging.basicConfig(level=logging.INFO) | |
| logger = logging.getLogger(__name__) | |
| if self.verbose > 0: | |
| logger.info(f"Run subprocess: {args}") |
|
Please fix conflicts. |
# Conflicts: # sdk/python/packages/flet/src/flet/cli/commands/build.py
FeodorFitsner
approved these changes
Jun 10, 2024
zrr1999
pushed a commit
to zrr1999/flet
that referenced
this pull request
Jul 17, 2024
* prettify "build" command cli output * build-platform-matrix table * consider sourcery-ai's suggestions * new option: --show-platform-matrix | black reformat * Set --show-platform-matrix default value to False * refactor template_data dict
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should now look like below: