-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TextStyle
properties: overflow
, word_spacing
, baseline
#3435
Conversation
Reviewer's Guide by SourceryThis pull request adds new properties ( File-Level Changes
Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ndonkoHenri - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 4 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
letterSpacing: json['letter_spacing'] != null | ||
? parseDouble(json['letter_spacing']) | ||
: null); | ||
fontSize: parseDouble(json["size"]), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue (bug_risk): Check for null values in JSON parsing.
Ensure that parseDouble and other parsing functions handle null values gracefully to avoid potential runtime errors.
Closes #3231
Summary by Sourcery
This pull request introduces new properties
overflow
,word_spacing
, andbaseline
to theTextStyle
class, enhancing text styling capabilities. Additionally, utility functions for parsing text properties have been refactored to support default values.overflow
,word_spacing
, andbaseline
properties toTextStyle
in both Dart and Python implementations.TextAlign
,TextOverflow
,TextCapitalization
, andTextBaseline
.