Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SearchView popup not to be opened on tap #3513

Merged
merged 1 commit into from
Jun 24, 2024
Merged

Conversation

InesaFitsner
Copy link
Contributor

@InesaFitsner InesaFitsner commented Jun 21, 2024

Currently, search View popup is opened on tap. Removed it so that user can call it from python instead.

Summary by Sourcery

Removed the automatic opening of the search view on tap, allowing users to control this behavior from Python instead.

Copy link
Contributor

sourcery-ai bot commented Jun 21, 2024

Reviewer's Guide by Sourcery

This pull request modifies the behavior of the search View popup in the SearchAnchorControl class. Specifically, it removes the automatic opening of the search View on tap, allowing users to call this functionality from Python instead.

File-Level Changes

Files Changes
packages/flet/lib/src/controls/search_anchor.dart Removed the automatic opening of the search View on tap, enabling users to trigger this action from Python.

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

@InesaFitsner InesaFitsner changed the title View is not opened on tap SearchView popup not to be opened on tap Jun 21, 2024
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @InesaFitsner - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@ndonkoHenri
Copy link
Contributor

Don't you think it should be the default behavior?

@FeodorFitsner
Copy link
Contributor

I think it should be decided by developer on Python side.

@ndonkoHenri
Copy link
Contributor

I think it should be decided by developer on Python side.

Ok, we could do it like that...

@FeodorFitsner FeodorFitsner merged commit 265c73e into main Jun 24, 2024
2 of 3 checks passed
@ndonkoHenri ndonkoHenri deleted the search-bar-test branch June 24, 2024 17:21
@ndonkoHenri ndonkoHenri mentioned this pull request Jul 4, 2024
1 task
zrr1999 pushed a commit to zrr1999/flet that referenced this pull request Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants