-
Notifications
You must be signed in to change notification settings - Fork 486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SearchView popup not to be opened on tap #3513
Conversation
Reviewer's Guide by SourceryThis pull request modifies the behavior of the search View popup in the File-Level Changes
Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @InesaFitsner - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
Don't you think it should be the default behavior? |
I think it should be decided by developer on Python side. |
Ok, we could do it like that... |
Currently, search View popup is opened on tap. Removed it so that user can call it from python instead.
Summary by Sourcery
Removed the automatic opening of the search view on tap, allowing users to control this behavior from Python instead.