Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unicode string in tooltip #3924

Closed
1 task done
lixxu opened this issue Sep 3, 2024 · 2 comments · Fixed by #3922
Closed
1 task done

unicode string in tooltip #3924

lixxu opened this issue Sep 3, 2024 · 2 comments · Fixed by #3922
Labels
duplicate This issue or pull request already exists status: awaiting response Further information is requested

Comments

@lixxu
Copy link
Contributor

lixxu commented Sep 3, 2024

Duplicate Check

Describe the bug

tooltip on IconButton shows unicode strings not actual strings, the example also not show the correct value if not English.
8e7a705847282ef788f079029a3181b

codes like below

def get_button(icon: str, func: Any, tooltip: str = "") -> ft.IconButton:
    return ft.IconButton(
        icon=getattr(ft.icons, icon.upper()),
        style=ft.ButtonStyle(
            shape=ft.RoundedRectangleBorder(radius=0),
        ),
        on_click=func,
        tooltip=tooltip,
    )

get_button("remove", self.click_min, "最小化")

Code sample

Code
[Paste your code here]

To reproduce

change the tooltip to non-English strings.
https://flet.dev/docs/controls/iconbutton#icon-buttons

Expected behavior

No response

Screenshots / Videos

Captures

[Upload media here]

Operating System

Windows

Operating system details

Windows 11

Flet version

0.24

Regression

No, it isn't

Suggestions

No response

Logs

Logs
[Paste your logs here]

Additional details

No response

@ndonkoHenri ndonkoHenri added the duplicate This issue or pull request already exists label Sep 3, 2024
@ndonkoHenri
Copy link
Contributor

I think this should have been fixed in #3920.

Can you try the latest prerelease: pip install Flet -U --pre

@ndonkoHenri ndonkoHenri added the status: awaiting response Further information is requested label Sep 3, 2024
@lixxu
Copy link
Contributor Author

lixxu commented Sep 3, 2024

yes, pre version fixed.

@lixxu lixxu closed this as completed Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists status: awaiting response Further information is requested
Projects
None yet
2 participants