Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unknown cli command hangs in endless loop [0.32.0-alpha.23] #628

Closed
TheDuc opened this issue Dec 14, 2020 · 1 comment
Closed

Unknown cli command hangs in endless loop [0.32.0-alpha.23] #628

TheDuc opened this issue Dec 14, 2020 · 1 comment
Assignees
Labels
bug Something isn't working
Milestone

Comments

@TheDuc
Copy link
Contributor

TheDuc commented Dec 14, 2020

Describe the bug
When running rnv via cli and using a not existing command results in an endless loop.

To Reproduce
Steps to reproduce the behavior:

  1. Run command npx rnv notexisting (or other not existing command)
  2. Observe logs

Expected behavior
To just log unknown command or offer help and show existing commands

Logs

% npx rnv notexisting

┌──────────────────────────────────────────────────────────────────────────────┐
│                                                                              │
│        ██████╗ ███████╗███╗   ██╗ █████╗ ████████╗██╗██╗   ██╗███████╗       │
│        ██╔══██╗██╔════╝████╗  ██║██╔══██╗╚══██╔══╝██║██║   ██║██╔════╝       │
│        ██████╔╝█████╗  ██╔██╗ ██║███████║   ██║   ██║██║   ██║█████╗         │
│        ██╔══██╗██╔══╝  ██║╚██╗██║██╔══██║   ██║   ██║╚██╗ ██╔╝██╔══╝         │
│        ██║  ██║███████╗██║ ╚████║██║  ██║   ██║   ██║ ╚████╔╝ ███████╗       │
│        ╚═╝  ╚═╝╚══════╝╚═╝  ╚═══╝╚═╝  ╚═╝   ╚═╝   ╚═╝  ╚═══╝  ╚══════╝       │
│                                                                              │
│        Version: 0.32.0-alpha.23                                              │
│        WARNING: this is a prerelease version.                                │
│        https://renative.org                                                  │
│        🚀 Firing up!...                                                      │
│        $ rnv notexisting                                                     │
│        Start Time: 12/14/2020, 10:33:58 AM                                   │
│                                                                              │
└──────────────────────────────────────────────────────────────────────────────┘

[ task ] registerEngine:engine-core[1]
[ task ] configureRuntimeDefaults[1] appId:null
[ task ] checkAndMigrateProject[1]
[ task ] loadPluginTemplates[1]
[ task ] _parsePluginTemplateDependencies[1] scope:root
[ task ] parseRenativeConfigs[1]
[ task ] getWorkspaceDirPath[1]
[ task ] _generatePlatformTemplatePaths[1]
[ task ] loadEngines[1]
[ task ] findSuitableTask[1]
[ task ] registerAllPlatformEngines[1]
[ task ] registerEngine:engine-rn[1]
[ task ] registerEngine:engine-rn-web[1]
[ task ] findSuitableTask[2]
[ task ] registerAllPlatformEngines[2]
[ task ] findSuitableTask[3]
[ task ] registerAllPlatformEngines[3]
[ task ] findSuitableTask[4]
[ task ] registerAllPlatformEngines[4]
[ task ] findSuitableTask[5]
[ task ] registerAllPlatformEngines[5]
[ task ] findSuitableTask[6]
[ task ] registerAllPlatformEngines[6]
(... etc ...)

Desktop (please complete the following information):

  • OS: Big Sur 11.0.1
  • Node Version 14.7.0
  • RNV Version 0.32.0-alpha.23
@TheDuc TheDuc added the bug Something isn't working label Dec 14, 2020
@pavjacko pavjacko self-assigned this Jan 4, 2021
@pavjacko pavjacko added this to the 0.32.0 milestone Jan 4, 2021
@pavjacko
Copy link
Member

pavjacko commented Jan 4, 2021

@TheDuc thx. another good catch! 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants