-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configure fails for emscripten/wasm build with 3.2.0-rc1 #2247
Comments
This should be fixed as of #2248. Please make sure that WASM builds correctly on |
Thanks. We'll check this. |
Looks like the error persists: https://github.com/agriyakhetarpal/python-flint/actions/runs/13710749723/job/38346563289 |
Then I don't understand it. Is it just the compiler that is incapable of using labels? Or is the host platform not really Zen 3? |
🤔 Emscripten should be capable of labels. The host isn't Zen 3, though. WebAssembly is architecture-agnostic, but its runtimes differ based on browser and OS/platform combos. I could try to bisect between 3.1.3 and 3.2.0-rc1 and find where the failure started. |
The problem isn't with FLINT. You have to specify the correct CPU. If you (indirectly) push Zen 3, it will try to spit out code for Zen 3. Perhaps |
I don't think Emscripten supports specifying CPUs, as it doesn't optimise for CPU instructions and WASM runtimes often use JIT compilation. Is there a baseline option that can be chosen, akin to |
There was a problem with the CI config meaning that the After fixing that the error does not persist so it looks like this is fixed. |
This fix was still necessary. It would be good if that can go into 3.2.0. Thanks Albin! |
Will keep it open until the full release. |
Building FLINT for wasm fails with 3.2.0-rc1 although it previously worked for 3.1. The build fails to configure with:
The configure script tries to determine the label suffix for assembly code but the assembly code cannot be used on wasm as it is only for x86_64 and arm64. I guess ideally configure would fall back on not using assembly here rather than erroring out.
To reproduce this first install emscripten (e.g..
sudo apt-get install emscripten
) and then build GMP, MPFR and FLINT but usingemconfigure
andemmake
instead of./configure
andmake
. I haven't actually tested these steps myself but you can see the commands in the CI job at https://github.com/flintlib/python-flint/pull/262/files.This comes from flintlib/python-flint#262 (comment) which is trying to build python-flint with the latest version of FLINT to run in the browser.
The text was updated successfully, but these errors were encountered: