Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import deepDiff from 'deep-diff' using Rollup is wrong. #128

Closed
moersing opened this issue May 10, 2018 · 3 comments
Closed

Import deepDiff from 'deep-diff' using Rollup is wrong. #128

moersing opened this issue May 10, 2018 · 3 comments

Comments

@moersing
Copy link

Hi, On the 1.0.0 version , I using import deepDiff from 'deep-diff' with Rollup, But I get an error :
Error: 'observableDiff' is not exported by node_modules/deep-diff/index.js.
I think this is a bug relative#93 , Because I found index.es.js file on the 0.3.8 version but the 1.0.0 not, Why did you deleted it ?

@flitbit
Copy link
Collaborator

flitbit commented May 17, 2018

I deleted index.es.js because it was redundant and complicated dev on this module. Since I only visit it once in a while I wanted it simplified. Can I get a link to Rollup?

@flitbit
Copy link
Collaborator

flitbit commented May 17, 2018

nm, found it.

@flitbit
Copy link
Collaborator

flitbit commented May 17, 2018

Seems ok. Problem with what Rollup is doing?

Transcript:

im5k:flitbit phillip$ node --version
v8.11.1
im5k:flitbit phillip$ node
> const diff = require('deep-diff')
undefined
> diff.observableDiff
[Function: observableDiff]
> .exit

@flitbit flitbit closed this as completed May 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant