Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support reading from datasets saved as jsonl #1443

Closed
norberttech opened this issue Feb 3, 2025 · 4 comments · Fixed by #1447
Closed

Support reading from datasets saved as jsonl #1443

norberttech opened this issue Feb 3, 2025 · 4 comments · Fixed by #1447
Milestone

Comments

@norberttech
Copy link
Member

Currently JSONL is supported only when writing, for symmetry we must add it also to the reader.

When reading jsonl all we need to do is read the json file line by line and, decode each line and turn it into a row that would be yielded after.

DX should be similar to writter:

from_json()->asJsonl()

@norberttech norberttech added this to the 0.11.0 milestone Feb 3, 2025
@norberttech norberttech moved this to Todo in Roadmap Feb 3, 2025
@norberttech
Copy link
Member Author

Reference to #1442 for inspiration

@norberttech
Copy link
Member Author

@jmortlock would you be interested in picking up this one?

@jmortlock
Copy link
Contributor

Sure thing i'll work on adding read support

@norberttech
Copy link
Member Author

Awesome! Let me know if you would need any assistance 💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants