Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(compiler)!: Force aqua header [LNG-308] #1028

Merged
merged 27 commits into from
Jan 18, 2024

Conversation

InversionSpaces
Copy link
Contributor

@InversionSpaces InversionSpaces commented Dec 20, 2023

Description

Force aqua header for all aqua source files, deprecate module keyword.

Implementation Details

  • Simplify header parsing
  • Raise semantic errors on absence of a header, module keyword and incorrect header position.

Checklist

  • Corresponding issue has been created and linked in PR title.
  • Proposed changes are covered by tests.
  • Documentation has been updated to reflect the changes (if applicable).
  • I have self-reviewed my code and ensured its quality.
  • I have added/updated necessary comments to aid understanding.

Reviewer Checklist

  • Tests have been reviewed and are sufficient to validate the changes.
  • Documentation has been reviewed and is up to date.
  • Any questions or concerns have been addressed.

Copy link

linear bot commented Dec 20, 2023

@InversionSpaces InversionSpaces marked this pull request as ready for review December 21, 2023 13:12
@InversionSpaces InversionSpaces added the e2e Run e2e workflow label Dec 21, 2023
@InversionSpaces InversionSpaces merged commit d057a5e into main Jan 18, 2024
10 checks passed
@InversionSpaces InversionSpaces deleted the feat/force-header-LNG-308 branch January 18, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run e2e workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants