Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(compiler): Type check arrow calls on services and abilities [LNG-315] #1037

Merged
merged 11 commits into from
Jan 10, 2024
Merged

fix(compiler): Type check arrow calls on services and abilities [LNG-315] #1037

merged 11 commits into from
Jan 10, 2024

Conversation

InversionSpaces
Copy link
Contributor

@InversionSpaces InversionSpaces commented Jan 9, 2024 •
edited by DieMyst
Loading

Description

Add type checking for method calls on abilities and services.

Proposed Changes

  • Add type checking in method calls (number of arguments, arguments types matching)
  • Refactor TypesAlgebra, remove dealing with ValueRaw inside it

Checklist

  • Corresponding issue has been created and linked in PR title.
  • Proposed changes are covered by tests.
  • Documentation has been updated to reflect the changes (if applicable).
  • I have self-reviewed my code and ensured its quality.
  • I have added/updated necessary comments to aid understanding.

Reviewer Checklist

  • Tests have been reviewed and are sufficient to validate the changes.
  • Documentation has been reviewed and is up to date.
  • Any questions or concerns have been addressed.

@linear Linear
Copy link

linear bot commented Jan 9, 2024

LNG-315 Invalid AIR generated on service call

@InversionSpaces InversionSpaces added the e2e Run e2e workflow label Jan 9, 2024
@InversionSpaces InversionSpaces marked this pull request as ready for review January 10, 2024 09:51
@InversionSpaces InversionSpaces merged commit d46ee03 into main Jan 10, 2024
15 of 19 checks passed
@InversionSpaces InversionSpaces deleted the fix/check-service-call-args-LNG-315 branch January 10, 2024 10:36
@fluencebot fluencebot mentioned this pull request Jan 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DieMyst DieMyst DieMyst approved these changes

Assignees
No one assigned
Labels
e2e Run e2e workflow
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@InversionSpaces @DieMyst