-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(compiler): Import abilities with use
[LNG-324]
#1077
Merged
Merged
+573
−136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
InversionSpaces
force-pushed
the
fix/use-ability-LNG-324
branch
from
February 13, 2024 16:31
1abe725
to
b593c7d
Compare
InversionSpaces
force-pushed
the
fix/use-ability-LNG-324
branch
from
February 28, 2024 17:27
4c52234
to
88fc402
Compare
It would be great to add integration tests too. Something that imports complex abilities in chain of 2-3 imported files. Such cases |
DieMyst
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix parsing and ability resolution so that abilities imported with
use
could be constructed and referred to.Proposed Changes
Try to convert property tokens as if they are access to symbols imported with
use
. Check if there is actually an import with alleged name. If so, handle converted tokens accordingly.Checklist
Reviewer Checklist