Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compiler): Import abilities with use [LNG-324] #1077

Merged
merged 17 commits into from
Feb 29, 2024

Conversation

InversionSpaces
Copy link
Contributor

@InversionSpaces InversionSpaces commented Feb 13, 2024

Description

Fix parsing and ability resolution so that abilities imported with use could be constructed and referred to.

Proposed Changes

Try to convert property tokens as if they are access to symbols imported with use. Check if there is actually an import with alleged name. If so, handle converted tokens accordingly.

Checklist

  • Corresponding issue has been created and linked in PR title.
  • Proposed changes are covered by tests.
  • Documentation has been updated to reflect the changes (if applicable).
  • I have self-reviewed my code and ensured its quality.
  • I have added/updated necessary comments to aid understanding.

Reviewer Checklist

  • Tests have been reviewed and are sufficient to validate the changes.
  • Documentation has been reviewed and is up to date.
  • Any questions or concerns have been addressed.

Copy link

linear bot commented Feb 13, 2024

@InversionSpaces InversionSpaces added the e2e Run e2e workflow label Feb 14, 2024
@InversionSpaces InversionSpaces removed the e2e Run e2e workflow label Feb 14, 2024
@InversionSpaces InversionSpaces added the e2e Run e2e workflow label Feb 14, 2024
@InversionSpaces InversionSpaces marked this pull request as ready for review February 28, 2024 17:26
@DieMyst
Copy link
Member

DieMyst commented Feb 29, 2024

It would be great to add integration tests too. Something that imports complex abilities in chain of 2-3 imported files. Such cases
can have bugs, based on past experience

@InversionSpaces InversionSpaces merged commit a6c8e75 into main Feb 29, 2024
9 checks passed
@InversionSpaces InversionSpaces deleted the fix/use-ability-LNG-324 branch February 29, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run e2e workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants