feat(language-server): Add types for types in LSP API #1078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| import scala.scalajs.js.JSConverters.* | ||
| import scalajs.js | ||
|
|
||
| sealed trait TypeJs extends js.Object { |
There was a problem hiding this comment.
Why not model them as enum?
Also I don't quite understand: don't you need to annotate class fields with @JSExport? Otherwise they should not be visible in js, should they?
There was a problem hiding this comment.
enum don't work with js.Object as far as I know.
Also, @JSExport makes scala class accessible from JS. extends js.Object makes these objects AS JS objects. So, I think we will rewrite definitions on js.Object too, to avoid redundant proxy conversions
language-server/language-server-api/.js/src/main/scala/aqua/lsp/TypeJs.scala
Outdated
Show resolved
Hide resolved
| "examples": "jest", | ||
| "pubsub": "node -r ts-node/register src/pubsub.ts", | ||
| "exec": "npm run compile-aqua && npm run prettify-compiled && node -r ts-node/register src/index.ts", | ||
| "run": "node -r ts-node/register src/index.ts", | ||
| "compile-aqua": "node --loader ts-node/esm ./src/compile.ts", | ||
| "compile-aqua:air": "aqua -i ./aqua/ -o ./compiled-air -a", |
There was a problem hiding this comment.
Suggested change
| "compile-aqua:air": "aqua -i ./aqua/ -o ./compiled-air -a", |
InversionSpaces
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add JS representation of types in compiler
Checklist
Reviewer Checklist