Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(compiler): Reimplement noXor compiler flag [LNG-347] #1096

Merged
merged 10 commits into from
Mar 5, 2024
Merged

feat(compiler): Reimplement noXor compiler flag [LNG-347] #1096

merged 10 commits into from
Mar 5, 2024

Conversation

InversionSpaces
Copy link
Contributor

@InversionSpaces InversionSpaces commented Mar 1, 2024 •
edited
Loading

Description

Reimplement once dropped noXor compiler flag. Setting it will disable error propagation behavior.

Implementation Details

Add Config type class for InliningState. Disable error propagating air generation based on passed flag.

Checklist

  • Corresponding issue has been created and linked in PR title.
  • Proposed changes are covered by tests.
  • Documentation has been updated to reflect the changes (if applicable).
  • I have self-reviewed my code and ensured its quality.
  • I have added/updated necessary comments to aid understanding.

Reviewer Checklist

  • Tests have been reviewed and are sufficient to validate the changes.
  • Documentation has been reviewed and is up to date.
  • Any questions or concerns have been addressed.

@linear Linear
Copy link

linear bot commented Mar 1, 2024

LNG-347 Reimplement `noXor` compiler flag

@InversionSpaces InversionSpaces added the e2e Run e2e workflow label Mar 1, 2024
@InversionSpaces InversionSpaces marked this pull request as ready for review March 1, 2024 18:37
@InversionSpaces InversionSpaces enabled auto-merge (squash) March 1, 2024 19:08
@InversionSpaces InversionSpaces requested review from DieMyst and alari March 1, 2024 19:08
@InversionSpaces InversionSpaces merged commit 5c7f6a8 into main Mar 5, 2024
11 of 17 checks passed
@InversionSpaces InversionSpaces deleted the feat/reimpliment-no-xor-LNG-347 branch March 5, 2024 03:45
@fluencebot fluencebot mentioned this pull request Mar 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DieMyst DieMyst DieMyst approved these changes

@alari alari Awaiting requested review from alari

Assignees
No one assigned
Labels
e2e Run e2e workflow
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@InversionSpaces @DieMyst