feat(compiler): CRDT-maps implementation #1142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation # Conflicts: # aqua-src/antithesis.aqua
| streamMap <<- "key one", "new" | ||
| streamMap <<- "key two", "" | ||
| resSecond = streamMap.keysStream() | ||
| <- resEmpty, resFirst, resSecond |
There was a problem hiding this comment.
Should not we join on result streams?
|
|
||
| for r <- relays par: | ||
| on r: | ||
| join map.get("time")[relays.length - 1] |
There was a problem hiding this comment.
Is not it join on an array that has no effect?
| getKeys(mapName, mapType) | ||
| case (KeysStream, Nil) => | ||
| getKeysStream(mapName, mapType) | ||
| case (n, args) => |
There was a problem hiding this comment.
Why not put this argument flattening inside getModel? It already flattens the id if it is a string literal. And contains uses getModel inside, so there will be no need to use it twice.
| @@ -129,7 +129,7 @@ trait TypesAlgebra[S[_], Alg[_]] { | |||
|
|
|||
| def typeToCollectible(token: Token[S], givenType: Type): OptionT[Alg, CollectibleType] | |||
|
|
|||
| def typeToStream(token: Token[S], givenType: Type): OptionT[Alg, StreamType] | |||
| def typeToStream(token: Token[S], givenType: Type, isMap: Boolean): OptionT[Alg, MutableStreamType] | |||
There was a problem hiding this comment.
nit: Personally, I don't like such bool flags that essentially separate two distinct methods inside.
Here it is just typeToStream(...): ...[..., StreamType] and typeToStreamMap(...): ...[..., StreamMapType].
InversionSpaces
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implementation of CRDT-maps in Aqua
Proposed Changes
https://www.notion.so/fluencenetwork/CRDT-Maps-in-Aqua-82d047246329446b8e1ca6f4db73228b?pm=c
Checklist
Reviewer Checklist