feat: copy structures implementation [fixes LNG-102] #646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # model/inline/src/main/scala/aqua/model/inline/raw/ApplyPropertiesRawInliner.scala
alari
approved these changes
Jan 19, 2023
| @@ -17,7 +19,7 @@ object ParMode extends MergeMode | |||
| * @param mergeMode how `flattenValues` and `predo` must be merged | |||
| */ | |||
| private[inline] case class Inline( | |||
| flattenValues: Map[String, ValueRaw] = Map.empty, | |||
| flattenValues: ListMap[String, ValueRaw] = ListMap.empty, | |||
| value match { | ||
| case v @ VarModel(name, _, _) => | ||
| for { | ||
| name <- Mangler[S].findAndForbidName(name + "_obj_copy") |
There was a problem hiding this comment.
- Pattern matching seems unnecessary there
- Variable shadowing looks overcomplicated, not sure which
nameis used where
| ) | ||
| case _ => | ||
| State.pure(vm -> Inline.empty) | ||
| private def flatVar[S: Mangler: Exports: Arrows]( |
There was a problem hiding this comment.
- Comment plz, what it does
flatis not a verb, maybeflatten? OrremoveProperties? OrflattenProperties?- It looks like not all the typeclasses are needed here, I see only
Manglerused
| ) { case (state, property) => | ||
| state.flatMap { case (vm, leftInline) => | ||
| unfoldProperty(vm, property).flatMap { | ||
| case (v, i) if !propertiesAllowed && v.properties.nonEmpty => |
There was a problem hiding this comment.
I cannot say I fully get what happens there
DieMyst
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes LNG-102