Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(compiler): Always generate last argument of fold [LNG-265] #947

Merged
merged 4 commits into from
Oct 30, 2023

Conversation

InversionSpaces
Copy link
Contributor

@InversionSpaces InversionSpaces commented Oct 27, 2023

Description

Always generate last argument of fold instruction in result AIR to make this explicit.

Proposed Changes

Removal of Option for for and fold models

Implementation Details

Self-descriptive

Checklist

  • Corresponding issue has been created and linked in PR title.
  • Proposed changes are covered by tests. No tests applicable
  • Documentation has been updated to reflect the changes (if applicable).
  • I have self-reviewed my code and ensured its quality.
  • I have added/updated necessary comments to aid understanding.

Reviewer Checklist

  • Tests have been reviewed and are sufficient to validate the changes.
  • Documentation has been reviewed and is up to date.
  • Any questions or concerns have been addressed.

@linear
Copy link

linear bot commented Oct 27, 2023

LNG-265 Always generate `last` argument of `fold`

AquaVM implicitly deduces last instruction in fold based on the instruction argument. To make it explicit, aqua should generate:

  • last = null for for and for … try
  • last = never for for … par and parseq

@InversionSpaces InversionSpaces added the e2e Run e2e workflow label Oct 30, 2023
@InversionSpaces InversionSpaces marked this pull request as ready for review October 30, 2023 09:33
@InversionSpaces InversionSpaces enabled auto-merge (squash) October 30, 2023 09:41
@InversionSpaces InversionSpaces merged commit 78ee753 into main Oct 30, 2023
11 of 17 checks passed
@InversionSpaces InversionSpaces deleted the feat/generate-fold-last-LNG-265 branch October 30, 2023 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run e2e workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants