fix(compiler): Incorrect focus on error [LNG-274] #959

DieMyst · 2023-11-02T05:24:52Z

Description

func arr(strs: []string) -> []string
  <- strs

this code throws StringOutOfBound instead of parser error

Proposed Changes

Pad strings that the compiler error renderer can point.

Checklist

Corresponding issue has been created and linked in PR title.
Proposed changes are covered by tests.
Documentation has been updated to reflect the changes (if applicable).
I have self-reviewed my code and ensured its quality.
I have added/updated necessary comments to aid understanding.

Reviewer Checklist

Tests have been reviewed and are sufficient to validate the changes.
Documentation has been reviewed and is up to date.
Any questions or concerns have been addressed.

linear · 2023-11-02T05:24:54Z

LNG-274 StringIndexOutOfBoundsException on correct code

func arr(strs: []string) -> []string
  <- strs

func test() -> i8:
  a = ["12", "34"]
  arr(a)
  <- 2

throws

[error] java.lang.StringIndexOutOfBoundsException: String index out of range: 37
…

DieMyst · 2023-11-02T05:27:37Z

also fixes LNG-272

io/src/test/scala/aqua/RenderingSpec.scala

Co-authored-by: InversionSpaces <[email protected]>

io/src/test/scala/aqua/RenderingSpec.scala

parser/src/main/scala/aqua/parser/Parser.scala

InversionSpaces · 2023-11-02T11:08:37Z

parser/src/main/scala/aqua/parser/lift/Span.scala

+  ): FocusedLine =
+    val end = idx + len
+    // if we want to point to the place after a string, pad this string with spaces
+    val padded =
+      if (str.length < idx + len) str.padTo(end, ' ')
+      else str
+    FocusedLine(
+      padded.substring(0, idx),
+      padded.substring(idx, end),
+      padded.substring(end)
+    )


Why not just use String#slice method?

Co-authored-by: InversionSpaces <[email protected]>

parser/src/main/scala/aqua/parser/lift/Span.scala

InversionSpaces · 2023-11-02T12:11:28Z

parser/src/main/scala/aqua/parser/lift/Span.scala

-    str.substring(idx + len)
-  )
+  ): FocusedLine =
+    val end = idx + len


nit: Could you wrap the method in {}?
I don't like indentation as scope marking

Co-authored-by: InversionSpaces <[email protected]>

pad strings for end of strings errors

86c170b

DieMyst requested a review from InversionSpaces November 2, 2023 05:24

DieMyst added the e2e Run e2e workflow label Nov 2, 2023

DieMyst enabled auto-merge (squash) November 2, 2023 06:55

Merge branch 'main' into LNG-274-incorrect-focus-on-error

4fe55d8