Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compiler): Allow returning resolved service as ability [LNG-266] #977

Merged
merged 27 commits into from
Nov 23, 2023

Conversation

InversionSpaces
Copy link
Contributor

@InversionSpaces InversionSpaces commented Nov 15, 2023

Description

Allow returning as ability from function a service resolved in body.

Proposed Changes / Implementation Details

  • Make ServiceType subtype of AbilityType
  • Fix renaming in ServiceIdTag

Checklist

  • Corresponding issue has been created and linked in PR title.
  • Proposed changes are covered by tests.
  • Documentation has been updated to reflect the changes (if applicable).
  • I have self-reviewed my code and ensured its quality.
  • I have added/updated necessary comments to aid understanding.

Reviewer Checklist

  • Tests have been reviewed and are sufficient to validate the changes.
  • Documentation has been reviewed and is up to date.
  • Any questions or concerns have been addressed.

Copy link

linear bot commented Nov 15, 2023

LNG-266 Allow returning resolved service as ability

aqua:

ability SpellAbility:
    store_log(log: string)

service SpellService:
    store_log(log: string)

func spell1min() -> SpellAbility:
    SpellService "spell-1min-id"
    <- SpellService

error:

Wrong value type, expected: ability SpellAbility{store_log: (log: string) :: ∅ -> ∅}, given: service SpellService{store_log: (log: string) :: ∅ -> ∅}

@InversionSpaces InversionSpaces added the e2e Run e2e workflow label Nov 15, 2023
@InversionSpaces InversionSpaces marked this pull request as ready for review November 15, 2023 15:10
@InversionSpaces InversionSpaces added e2e Run e2e workflow and removed e2e Run e2e workflow labels Nov 22, 2023
@InversionSpaces InversionSpaces enabled auto-merge (squash) November 23, 2023 10:00
@InversionSpaces InversionSpaces merged commit 2d4b2ae into main Nov 23, 2023
9 checks passed
@InversionSpaces InversionSpaces deleted the fix/return-service-ability-LNG-266 branch November 23, 2023 10:12
DieMyst added a commit that referenced this pull request Nov 28, 2023
…977)

* Refactor

* Refactor type system

* Remove println

* Fix renaming

* Add unit tests

* Do not convert to call arrow

* Check ability

* Refactor captured values resolution

* Remove println

* Fix fields gathering

* Remove println

* Remove println

* Fix renaming, export ability

* Rename only abilities

* Fix unit tests

* Fix captured arrows renaming

* Add comments

* Refactor

* Rename only arrows

* Add comments, refactor

* Add comments

* Rename method

* Add integration test

---------

Co-authored-by: Anatolios Laskaris <[email protected]>
Co-authored-by: Dima <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run e2e workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants