Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(compiler): Generate empty calls to responseHandlerSrv [LNG-286] #979

Merged
merged 2 commits into from
Nov 17, 2023

Conversation

InversionSpaces
Copy link
Contributor

@InversionSpaces InversionSpaces commented Nov 17, 2023

Description

Generate empty call to reponse service if there are no return values so that js-client could know if execution finished.

Checklist

  • Corresponding issue has been created and linked in PR title.
  • Proposed changes are covered by tests.
  • Documentation has been updated to reflect the changes (if applicable).
  • I have self-reviewed my code and ensured its quality.
  • I have added/updated necessary comments to aid understanding.

Reviewer Checklist

  • Tests have been reviewed and are sufficient to validate the changes.
  • Documentation has been reviewed and is up to date.
  • Any questions or concerns have been addressed.

Copy link

linear bot commented Nov 17, 2023

LNG-286 Generate empty calls to `responseHandlerSrv`

For js-client to know when to mark particle execution as completed in case there are no return values from aqua function called, aqua compiler should generate call to responseHandlerSrv with empty parameters.
A flag could be added to compiler to disable this.

@InversionSpaces InversionSpaces added the e2e Run e2e workflow label Nov 17, 2023
@InversionSpaces InversionSpaces marked this pull request as ready for review November 17, 2023 10:16
@InversionSpaces InversionSpaces enabled auto-merge (squash) November 17, 2023 10:25
@InversionSpaces InversionSpaces merged commit cee4448 into main Nov 17, 2023
9 checks passed
@InversionSpaces InversionSpaces deleted the feat/empty-response-LNG-286 branch November 17, 2023 10:43
DieMyst pushed a commit that referenced this pull request Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run e2e workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants