feat(decider,chain-connector): support deal removal [fixes NET-515] #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmd-fl
changed the title
kmd-fl
changed the title
.fluence/aqua/services.aqua
Outdated
There was a problem hiding this comment.
Could you add a header to this file?
There was a problem hiding this comment.
It's generated by fcli. I can add it for tests or smth, but it'll be overridden in the next compilation.
| @@ -0,0 +1,43 @@ | |||
| module DealStatus declares * | |||
There was a problem hiding this comment.
Suggested change
| module DealStatus declares * | |
| aqua DealStatus declares * |
There was a problem hiding this comment.
Every aqua file in this repo uses module, not aqua. I guess, we'll need to fix it in a separate PR.
But I like module more than aqua. In this repo, all aqua files but one is a library. I hate the idea of calling everything aqua.
folex
reviewed
Dec 4, 2023
folex
reviewed
Dec 4, 2023
folex
reviewed
Dec 4, 2023
folex
reviewed
Dec 4, 2023
folex
reviewed
Dec 4, 2023
src/services/chain-connector/modules/chain_connector/src/chain/u256.rs
Outdated
Show resolved
Hide resolved
folex
reviewed
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support deal removal when a developer ends a deal.
Note that we don't yet support cases when a compute provider exists a deal or when a developer kicks a compute provider from a deal.
Now, the decider polls statuses of deals and removes a deal when its status is
ended. We add reactions to active/inactive statuses later.I checked deal removal with FCLI, local chain, and custom relay with the updated decider.
DID NOT remove the logic of a worker removal based on a mailbox message. Maybe need to.Disabled removal via mailbox, but left the code as an example