fix: Enable publishing of js-client-isomorphic [fixes DXJ-516] #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shamsartem
reviewed
Oct 26, 2023
.github/release-please/config.json
Outdated
| @@ -9,6 +9,9 @@ | |||
| ], | |||
| "packages": { | |||
| "packages/core/js-client": {}, | |||
| "packages/core/js-client-isomorphic": { | |||
| "release-as": "0.1.0" | |||
There was a problem hiding this comment.
don't really know about how release please is configured. What does this setting mean? will it be removed in the future? looks a bit concerning to me that there is an exact number here
There was a problem hiding this comment.
release-as will make this package version set to 0.1.0 permanently.
If you want to set the first version to 0.1.0 you need to add it to .github/release-please/manifest.json
There was a problem hiding this comment.
Yes, probably we can make it different way. I will release 0.1.0 manually and set that to manifest instead of release-as
nahsi
approved these changes
Oct 26, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.