Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: JS-client bugs and tech debt [fixes DXJ-520] #374

Merged
merged 9 commits into from
Nov 6, 2023
Merged

fix: JS-client bugs and tech debt [fixes DXJ-520] #374

merged 9 commits into from
Nov 6, 2023

Conversation

akim-bow
Copy link
Contributor

@akim-bow akim-bow commented Nov 3, 2023

No description provided.

@linear Linear
Copy link

linear bot commented Nov 3, 2023

DXJ-520 Fix js-client bugs

  • marine-js should dep not devDep
  • node integration test has incorrect js-client import
  • should export ConnectionState type from the client

@akim-bow akim-bow requested a review from shamsartem November 3, 2023 10:02
@akim-bow akim-bow added the e2e Run e2e workflow label Nov 3, 2023
@akim-bow akim-bow enabled auto-merge (squash) November 6, 2023 09:56
@akim-bow akim-bow disabled auto-merge November 6, 2023 09:56
@akim-bow akim-bow enabled auto-merge (squash) November 6, 2023 09:56
@akim-bow akim-bow merged commit b460491 into master Nov 6, 2023
8 checks passed
@akim-bow akim-bow deleted the dxj-520 branch November 6, 2023 10:42
@fluencebot fluencebot mentioned this pull request Nov 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shamsartem shamsartem shamsartem approved these changes

Assignees
No one assigned
Labels
e2e Run e2e workflow
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akim-bow @shamsartem