fix: Update libp2p deps #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
January 18, 2024 22:37
shamsartem
reviewed
Jan 19, 2024
Comment on lines
85
to
94
| const DOCKER_NOX_DENY_CONDITION: DenyCondition = (ma) => { | ||
| const [routingProtocol] = ma.stringTuples(); | ||
| const host = routingProtocol?.[1]; | ||
|
|
||
| return ( | ||
| host === undefined || host.startsWith("nox-") || host.startsWith("10.50.10") | ||
| ); | ||
| }; | ||
|
|
||
| const DENY_CONDITIONS = [DOCKER_NOX_DENY_CONDITION]; |
There was a problem hiding this comment.
I would just use camelCase for these variables, they are not really constants
shamsartem
reviewed
Jan 19, 2024
| const host = routingProtocol?.[1]; | ||
|
|
||
| return ( | ||
| host === undefined || host.startsWith("nox-") || host.startsWith("10.50.10") |
There was a problem hiding this comment.
I am understanding correctly that when this is true - then dialing this multiaddr is forbidden?
why specifically nox- and 10.50.10. Would be nice to leave the comment about that
There was a problem hiding this comment.
there should be a more general way to handle that
There was a problem hiding this comment.
what if non-available addresses returned in real life, not in tests?
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.