Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ctrl+C (SIGINT) won't be effective on Windows after fleet support on Windows is merged #7985

Closed
cosmo0920 opened this issue Sep 28, 2023 · 0 comments · Fixed by #7986
Closed

Comments

@cosmo0920
Copy link
Contributor

cosmo0920 commented Sep 28, 2023

Bug Report

Describe the bug

After merging fleet management support on Windows, SIGINT won't work on Windows.
This is because ctrl handlers are working on the separated thread from the main thread loop and prioritized handling of the signals on console.
This leads SIGINT won't work on Windows.

To Reproduce

  • Steps to reproduce the problem:
  1. Run fluent-bit on cmd.exe ore powershell
  2. Send SIGINT signal (Press Ctrl+C)
  3. Nothing happen 💥

Expected behavior

Printed caught signal (SIGINT) and terminated fluent-bit process.

Screenshots

Your Environment

  • Version used: After commit: dff5982
  • Configuration: None. Only commandline options should be reproduced this issue.
  • Environment name and version (e.g. Kubernetes? What version?): Windows 11
  • Server type and version:
  • Operating System and version: Windows 11 Pro 22H2
  • Filters and plugins:

Additional context

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant