Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display active keys without playing a note? #113

Open
the-t-in-rtf opened this issue Sep 1, 2016 · 5 comments
Open

Display active keys without playing a note? #113

the-t-in-rtf opened this issue Sep 1, 2016 · 5 comments

Comments

@the-t-in-rtf
Copy link
Contributor

In my own work, I have a single page that is integrated both with a MIDI controller and with an onscreen instance of sisiliano. I would like for the keys hit on the MIDI controller to be highlighted onscreen, but without necessarily playing a note. I would like to be able to optionally specify the color, so that (for example) multiple collaborators could see the notes they are hitting on a single sisiliano instance. Anyway, is anything like that possible? If it's not and you're open to the idea, let me know, I might be able to submit a pull request.

@dinukadesilva
Copy link
Collaborator

could you please explain more... do you have already done the required change in a fork. If so I can have a look

@the-t-in-rtf
Copy link
Contributor Author

the-t-in-rtf commented Sep 5, 2016

I am using sisiliano in combination with Flocking and a MIDI controller. I want to enable collaboration between one user (using the MIDI controller) and another using a web browser. I want to be able to display the fact that a key is active without doing anything that would result in the note being played twice.

@the-t-in-rtf
Copy link
Contributor Author

I have not prepared a pull because I want to make sure it's not already possible.

@dinukadesilva
Copy link
Collaborator

understood @the-t-in-rtf

We can do that by adding an event. The current implementation has not provided that yet.

@colinbdclark
Copy link

It sounds like you'll want to introduce a slightly more fine-grained semantic for "selection" in the keyboard. At the moment, when a key is "selected," it's also "active." But it sounds like @the-t-in-rtf wants to be able to select or highlight a key on the keyboard without activating it. I imagine that, in the long run, we'll want to modelize the keyboard so that it explicitly keeps track of which keys are active (and in Tony's case, which ones are selected/highlighted).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants