Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to specify the starting pitch? #114

Open
the-t-in-rtf opened this issue Sep 1, 2016 · 4 comments
Open

How to specify the starting pitch? #114

the-t-in-rtf opened this issue Sep 1, 2016 · 4 comments

Comments

@the-t-in-rtf
Copy link
Contributor

I noticed in working with the sisiliano that the default starting point is very low. Ideally, I would like to have a small "viewport" very close to middle C. I could not find a way to do this, but perhaps I just don't understand the options:

                length: 20,
                start:  0,
                activeArea: {
                    start: 0,
                    end: 10
                }

I have tried a higher start, which doesn't seem to work. Is that the right parameter?

Anyway, in the mean time, I just add a 4 octave offset to the returned pitch, but think it might be more generally useful to be able to pick an octave.

@dinukadesilva
Copy link
Collaborator

yes @the-t-in-rtf ....

Seems, it's a bit misleading.

By the way active area defined the area accessible by the keyboard.

And I think, we need

  1. a way to define the pitch
  2. a way to define the starting note of the octave. (A-G, 0-11)

For now start parameter is trying to do both. And yes, it's a bit misleading and not properly working as well.

What do think about having two parameters. "pitch" and "startingNote"

@the-t-in-rtf
Copy link
Contributor Author

Having a separate pitch field seems helpful. Just to clarify when you say "the starting note of the octave", you mean the first key that will be displayed on the left side of the virtual piano?

@dinukadesilva
Copy link
Collaborator

you are correct @the-t-in-rtf

@colinbdclark
Copy link

Can you clarify for me what the difference between the pitch and startingNote fields will be, just so I fully understand the idea?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants